Fix test under darwin - Githubissues

elastic / elastic-agent-shipper

Data shipper for the Elastic Agent - single, unified way to add monitoring for logs, metrics, and other types of data to a host.

Other

9 stars 19 forks source link

Fix test under darwin #250

Closed fearful-symmetry closed 1 year ago

fearful-symmetry commented 1 year ago

What does this PR do?

This fixes an issue with the TestUnmanaged test failing on Darwin, as the filename was too long. This also makes the test not rely on a timer, and instead waits until the unix socket is available.

This also fixes a missing error check in RunUnmanaged()

Why is it important?

This is causing test failures.

Checklist

[x] My code follows the style guidelines of this project
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added an entry in CHANGELOG.md or CHANGELOG-developer.md.

mergify[bot] commented 1 year ago

This pull request does not have a backport label. If this is a bug or security fix, could you label this PR @fearful-symmetry? 🙏. For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed branches, such as:

backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

elasticmachine commented 1 year ago

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

#### Build stats * Start Time: 2023-02-15T22:39:21.394+0000 * Duration: 15 min 25 sec

:grey_exclamation: Flaky test report

No test was executed to be analysed.

:robot: GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with: - `/test` : Re-trigger the build.