Closed fearful-symmetry closed 1 year ago
This pull request does not have a backport label. If this is a bug or security fix, could you label this PR @fearful-symmetry? 🙏. For such, you'll need to label your PR with:
To fixup this pull request, you need to add the backport labels for the needed branches, such as:
backport-v8./d.0
is the label to automatically backport to the 8./d
branch. /d
is the digitthe below badges are clickable and redirect to their specific view in the CI or DOCS
![]()
![]()
![]()
![]()
![]()
#### Build stats * Start Time: 2023-04-18T17:03:57.150+0000 * Duration: 18 min 22 sec
No test was executed to be analysed.
To re-run your PR in the CI, just comment with: - `/test` : Re-trigger the build.
What does this PR do?
Closes https://github.com/elastic/elastic-agent-shipper/issues/262
This PR adds infinite retry functionality, and completely refactors the elasticsearch health monitor. In detail
max_retries
is set to-1
, this enables "infinite" retry, which just sets the ES MaxRetries toMaxInt
.OnFailure
, the monitor instead watches the raw HTTP return codes coming from the elasticsearch transport, and checks the deltas.Why is it important?
We want infinite retry.
Checklist
CHANGELOG.md
orCHANGELOG-developer.md
.How to test this PR locally
Pull down and build
Run either standalone or with agent
Set
max_retries
to-1
:Ensure that events send properly
Break Elasticsearch
Run again, ensure that the shipper reports a degraded state