add PssFreeSnapshot - Githubissues

leehinman commented 7 months ago

What does this PR do?

Frees the memory that is allocated when PssCaptureSnapshot is called.

memory leak

[ ] Written by hand. Need to figure out what needs to happen for "go generate" to work. Does not work from Mac.

run metricbeat 8.11.0 or 8.11.1 on Windows, notice memory consumption of metricbeat continually climbs
rebuild metricbeat using this path
memory consumption rises in first 10min or so, but is steady after that

nimarezainia commented 7 months ago

Thank you @leehinman

amolnater-qasource commented 7 months ago

Hi @pierrehilbert We have revalidated this PR on latest 8.11.0 BC1 kibana cloud environment and found it working fine :

Observations:

We observe 3 windows agents and 1 metricbeat on different hosts.
We didn't observe any memory leaks under windows Performance Monitor for keeping them over 18 hours .

Build details: VERSION: 8.11.2 BC1 BUILD: 68299 COMMIT: 92746356b61c3e3ac62b6d7045727f8d737fa4b5 Artifact link: https://staging.elastic.co/8.11.2-c2650cf6/downloads/beats/elastic-agent/elastic-agent-8.11.2-windows-x86_64.zip

Screen Recording:

Hence we are marking this as [QA:Validated].

Please let us know if we are missing anything here. Thanks!