elastic / elastic-agent-system-metrics

Apache License 2.0
0 stars 23 forks source link

Change cgroups log line from `Infof` from `Debugf` #175

Closed fearful-symmetry closed 3 months ago

fearful-symmetry commented 3 months ago

What does this PR do?

This is a one-liner that removes an erroneous Infof() debug line that should have been a Debugf() line.

Why is it important?

This can create lots of logging noise.

Checklist

cmacknz commented 3 months ago

Did a quick spot check and this looks like the only thing that should have been debug level:

❯ rg '\.Info' metric/system
metric/system/host/host.go
80:             info := h.Info()

metric/system/diskio/diskstat_windows_helper.go
144:            logp.L().Named("diskio").Info("The registry key EnableCounterForIoctl at HKLM:SYSTEM\\CurrentControlSet\\Services\\Partmgr has been created in order to enable the performance counters")

metric/system/cgroup/util.go
480:                            logp.L().Infof("using root mount %s and path %s", r.cgroupMountpoints.ContainerizedRootMount, path)

metric/system/cgroup/cgv2/io_helper_linux.go
46:             fInfo, dirErr := d.Info()