search

elastic / elastic-agent

Elastic Agent - single, unified way to add monitoring for logs, metrics, and other types of data to a host.
Other
16 stars 144 forks source link

Update MacOS keychain support to use non-deprecated API #2961

Open faec opened 1 year ago

faec commented 1 year ago

As mentioned in https://github.com/elastic/elastic-agent/issues/2639, most build and test actions on Mac produce a lot of noisy warning text related to the deprecation (in MacOS 10.10) of the old SecKeychain functions in Security.framework. We can suppress the build warnings for short-term convenience, but the oldest MacOS we support is 10.13, so we no longer need to support this deprecated API -- we should migrate our keychain handling to the current supported alternative.

elasticmachine commented 1 year ago

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

jlind23 commented 7 months ago

@pchila is this something you touched touch while working on https://github.com/elastic/elastic-agent/issues/3866?

pchila commented 7 months ago

@jlind23 I didn't touch the internal implementation of the Mac OS keychain vault, I only separated the 2 implementations of vaults we have so that we can use both on darwin (see https://github.com/elastic/elastic-agent/pull/4362).

If we need to change the implementation to move away from deprecated APIs there should be no conflicts (also, it still needs to be done 😅 )