[8.x](backport #6060) [helm] add lint checks for renderExamples

mergify[bot] commented 2 days ago

What does this PR do?

This PR extends the Helm lint checks in our CI pipeline to validate all examples in the Helm chart. Previously, the helm template command passed successfully but was insufficient because helm lint could still fail. By ensuring comprehensive linting, we address inconsistencies and prevent errors during deployment.

Key changes include:

Adding additional lint checks to cover example configurations in the Helm chart.

Why is it important?

This change is important to ensure consistency across our Helm chart configurations. By extending the lint checks to include all examples, we can catch issues ( such as the ones seen in this Buildkite job) early in the CI pipeline, reducing the risk of deployment failures.

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have made corresponding change to the default configuration files
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added an entry in ./changelog/fragments using the changelog tool
[ ] I have added an integration test or an E2E test

Disruptive User Impact

This change does not introduce any disruptive impact on users. The enhancements are internal to the CI validation process and do not affect end-user experience directly.

How to test this PR locally

Run helm template ./deploy/helm/elastic-agent -f ./deploy/helm/elastic-agent/examples/kubernetes-default/agent-kubernetes-values.yaml to ensure it passes.
Run helm lint ./deploy/helm/elastic-agent -f ./deploy/helm/elastic-agent/examples/kubernetes-default/agent-kubernetes-values.yaml and confirm that the lint checks also pass without errors.

mage helm:renderExamples does lint validation for all examples as well