Let's support ≤ 6 version.

elastic / elastic-github-actions

This action spins up an Elasticsearch instance that can be accessed and used in your subsequent steps.

Apache License 2.0

53 stars 37 forks source link

Closed miyataka closed 4 years ago

miyataka commented 4 years ago

cla-checker-service[bot] commented 4 years ago

💚 CLA has been signed

miyataka commented 4 years ago

I have signed the CLA now. How to rerun the CLA agreement checker bot?

miyataka commented 4 years ago

@delvedor Would you please review this PR?

miyataka commented 4 years ago

fixed. and this is CI result

delvedor commented 4 years ago

Almost there! :)

The Elasticsearch 6.x configuration must be updated to accept multiple nodes, in the multi-node cluster test with Elasticsearch 6.x, there is only one node: https://github.com/miyataka/elastic-github-actions/runs/689663048?check_suite_focus=true#step:8:9

miyataka commented 4 years ago

I see... please wait..

miyataka commented 4 years ago

@delvedor Sorry, late reply. I've fixed review point.

delvedor commented 4 years ago

Looks ok! Can you merge the upstream master branch in your fork? So we can also see the build result here in the pr :)

miyataka commented 4 years ago

Looks ok! Can you merge the upstream master branch in your fork? So we can also see the build result here in the pr :)

Yeesssssssss! I've merged.

miyataka commented 4 years ago

ping @delvedor