search

elastic / elastic-integration-corpus-generator-tool

Command line tool used for generating events corpus dynamically given a specific integration
Other
21 stars 12 forks source link

Do not expose GenState #110

Closed aspacca closed 11 months ago

aspacca commented 11 months ago

GenState was initially owned and initialized by the invoker of the generator library. More or less since the introduction of the template engines, the state of the generator is owned by the generator instance itself, but still it was passed to the Generator.Emit() method that would override the state passed by the invoker. This is counter intuitive and could lead in the wrong assumption from the generator consumer about the ownership of the state. This PR removes passing the state to Generator.Emit() and makes the state and its factory (GenState, NewGenState()) private

aspacca commented 11 months ago

@scunningham , please review this PR. the generator tool made quite some progress since v0.3.0 that you introduced in horde specifically the json generation according to the fields schema is faster now I'd suggest you to upgrade to the new version we will release (v0.7.0) after merging this PR

another break in the API is that the factory that horde uses (https://github.com/elastic/elastic-integration-corpus-generator-tool/blob/main/pkg/genlib/generator.go#L168) not takes the tot events to generate as part of the parameters, and the state is indeed owned by the generator