Closed gizas closed 6 months ago
gizas
commented
8 months ago @martijnvg FYI the kubernetes.pod.status.scheduled , kubernetes.pod.status.ready and kubernetes.pod.status.phase belong to kubernetes.state_pod and respectively the kubernetes.container.status.phase belongs to kubernetes.state_container datasets.
The current datasets in the template are for container and pod that come from kubelet and not from kube-state metrics as the above
Screenshots that prove the above
martijnvg
commented
8 months ago The current datasets in the template are for container and pod that come from kubelet and not from kube-state metrics as the above
@gizas The reason why I mentioned these fields to you before is that we do have searches using these fields (status_per_pod_* searches). So then I think this searches are targeting the wrong data stream? Currently the it targets the k8s-pod data stream. I think we should either remove these searches or add the kube state data stream back to the track?
ruflin
commented
8 months ago @gizas Why are we adding these here instead of the integration repo?
gizas
commented
7 months ago @martijnvg (as we synced inetrnally) this the visualisation that needs update: Operations file
So either we remove "status_perpod{{name}}", either we can remove just the filters. I will try to see If I can produce one without the filter. I will include this in the next rally track update
@ruflin nw, it is still this time where we housekeep both repos. I will sync with @aspacca and will also update the integrations. Eventually the integrations will be the only source of truth
martijnvg
commented
7 months ago So either we remove "status_perpod{{name}}", either we can remove just the filters. I will try to see If I can produce one without the filter. I will include this in the next rally track update
+1 - If the search doesn't make logical sense without the filters we can remove it.
On Thu, Jan 11, 2024 at 3:52 PM Andrew Gizas @.***> wrote:
@martijnvg https://github.com/martijnvg (as we synced inetrnally) this the visualisation that needs update: Operations file https://github.com/elastic/rally-tracks/blob/master/tsdb_k8s_queries/operations/default.json#L789
So either we remove "status_perpod{{name}}", either we can remove just the filters. I will try to see If I can produce one without the filter. I will include this in the next rally track update
@ruflin https://github.com/ruflin nw, it is still this time where we housekeep both repos. I will sync with @aspacca https://github.com/aspacca and will also update the integrations. Eventually the integrations will be the only source of truth
— Reply to this email directly, view it on GitHub https://github.com/elastic/elastic-integration-corpus-generator-tool/pull/126#issuecomment-1887348924, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAENWRKRT4SCBN22BLUDXGDYN74BNAVCNFSM6AAAAABBU5BQ52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBXGM2DQOJSGQ . You are receiving this because you were mentioned.Message ID: <elastic/elastic-integration-corpus-generator-tool/pull/126/c1887348924@ github.com>
gizas
commented
7 months ago @aspacca , @martijnvg can we also merge this as long as the relevant https://github.com/elastic/rally-tracks/pull/551 is already merged? If no objections
gizas
commented
7 months ago @aspacca once you get back I see that my ci tests are failing:
RUN Test_CardinalityWithTextTemplate
generator_with_text_template_test.go:57: for type keyword, with template: {"alpha":"{{generate "alpha"}}", "beta":"{{generate "beta"}}"}
generator_with_text_template_test.go:57: for type integer, with template: {"alpha":{{generate "alpha"}}, "beta":{{generate "beta"}}}
generator_with_text_template_test.go:124: Expected cardinality of 200 got 116
generator_with_text_template_test.go:57: for type float, with template: {"alpha":{{generate "alpha"}}, "beta":{{generate "beta"}}}
generator_with_text_template_test.go:57: for type geo_point, with template: {"alpha":"{{generate "alpha"}}", "beta":"{{generate "beta"}}"}
generator_with_text_template_test.go:57: for type ip, with template: {"alpha":"{{generate "alpha"}}", "beta":"{{generate "beta"}}"}
generator_with_text_template_test.go:57: for type date, with template: {"alpha":"{{generate "alpha"}}", "beta":"{{generate "beta"}}"}
--- FAIL: Test_CardinalityWithTextTemplate (1.29s)Although locally in my pc are successful. Not urgent but let see it once back
aspacca
commented
6 months ago @aspacca once you get back I see that my ci tests are failing:
it seems they are floating tests. I will review once they will pop up again
Context
The Cpu and Memory fields of K8s had hardcoded values in previous templates. This PR tries to generate more realistic values for fields:
Tests
With new templates: For container:
For Pod: