elastic / elastic-integration-corpus-generator-tool

Command line tool used for generating events corpus dynamically given a specific integration
Other
22 stars 12 forks source link

`aws.billing` template schema-b #43

Closed endorama closed 1 year ago

endorama commented 1 year ago

Adds aws.billing schema-b template and config.

See https://github.com/elastic/elastic-integration-corpus-generator-tool/pull/43#issuecomment-1410470148

elasticmachine commented 1 year ago

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

#### Build stats * Start Time: 2023-03-06T11:09:25.780+0000 * Duration: 3 min 47 sec #### Test stats :test_tube: | Test | Results | | ------------ | :-----------------------------: | | Failed | 0 | | Passed | 65 | | Skipped | 0 | | Total | 65 |

:robot: GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with: - `/test` : Re-trigger the build.

endorama commented 1 year ago

@aspacca may you please have a look at the fields definition? In this template I need to generate timestamps in ISO8601 and SYSLOG formats (see integrations ingest pipeline).

I opened #44 to track this discussion, as digging a bit deeper it may be easy to achieve but requires discussing the possible trade offs.

endorama commented 1 year ago

/test/

endorama commented 1 year ago

I'm sorry I completely messed up this PR. The title is for aws.ec2_logs, I started adding schema-a for it them did schema-b for aws.billing.

I then removed schema-a for ec2_logs, so this PR contains schema-b for aws.billing. As there have been an extensive review, I renamed this to aws.billing. Sorry for this confusion :(

aspacca commented 1 year ago

just a minor comment, @endorama

endorama commented 1 year ago

@aspacca I added an helper function for AWS AZs in a9328bd (#43), I find this approach more streamlined and easy to use, let me know what you think.

aspacca commented 1 year ago

👍 good to merge for me