elastic / elastic-otel-java

Apache License 2.0
10 stars 9 forks source link

Build refactor: Move signing and publishing to convention in buildSrc #151

Closed JonasKunz closed 4 months ago

JonasKunz commented 5 months ago

We currently copy-paste the buildscript configuring the signing and publication (e.g. to inferred-spans). We should use a gradle convention plugin instead.

In general, we should try to remove as much logic as possible from the subprojects {} call in the root project, as this makes the build difficult to understand and is not recommended. We shoult stick to only doing very basic things which are guaranteed to be always the same for all projects, such as assigning the groupid and version.

SylvainJuge commented 5 months ago

As the artifact signature and publishing conventions are only applied in CI when actually publishing to a remote repository, the best way to test any change here is probably to

jackshirazi commented 5 months ago

this should go into a build readme