Open gizas opened 8 months ago
@aspacca @ruflin how should this error be handled? is it ok to continue without collecting this data before running the benchmarks? should we retry? or fail fast?
@jsoriano now the error does not break the collection of data as described above. So it is not a blocker in my tests.
So my suggestion is that when command includes dry-run
, then the existence of the index is not needed and we can ignore it. What do you think?
@jsoriano, @gizas
I've dig a little more in the error. contrary to my initial expectation, it is not related to cleaning the index that's the target of the rally track.
when you ran the benchmark rally
command you have to option to define a second ES cluster used as metrics store.
in this case an index is created (if it does not already exist) on that ES cluster where to store the metrics, and a call is made to the refresh API on the index.
while if no metrics store ES cluster is defined, index creation is skipped, the same does not happen for the refresh API call. hence the error. we should change the current behaviour and skip the refresh API call in this case.
beware that in the case of the metrics store ES cluster is defined, the call is made, and the error could occur.
it is ok to continue without collecting the metrics, but we should both improve the feedback to the user making clear that the metrics were not collected, and at the same time lower the level of the error to WARN
, to avoid the confusion that the problem should be considered a blocking one.
We are testing with main elastic-package and specifically we use the
elastic-package benchmark rally
with the templates of kubernetes integration.The package returns an error which does not break the output extraction of corpora data
Detalis:
Either make the error as info or lets try to suppress it