[META] Support ARM in developer pipeline

elastic / elastic-package

elastic-package - Command line tool for developing Elastic Integrations

Other

49 stars 116 forks source link

[META] Support ARM in developer pipeline #539

Open jlind23 opened 3 years ago

jlind23 commented 3 years ago

Purpose of this Meta issue is to track all issues related to ARM support for all of our developer pipelines.

Linked issues:

jlind23 commented 2 years ago

Per discussed with @elastic/ecosystem the first step will be to put in a place a CI pipeline using a M1 worker and executing some standards command on it.

mrodm commented 2 months ago

Created PRs to add new steps to run unit tests in both package-registry and elastic-package repositories:

In elastic-package, it would be interesting to add another step to test running elastic-package stack up in MacOS ARM. However, it requires to install docker and docker-compose in the VM, and I've been not able to achieve that for the time being.

Do you recall if there is anything else that it could be added as part of the CI pipeline to be tested without docker/docker-compose in the meantime @jsoriano ?

mrodm commented 2 months ago

Testing here to add a new step to test building packages in Macos ARM (without installing them): https://github.com/elastic/elastic-package/pull/2030

mrodm commented 2 months ago

After being merged the PRs mentioned above, now there is some testing in Macos ARM:

elastic-package and package-registry run unit tests on Macos ARM.
elastic-package tests also a specific command elastic-package build.
- Not able to run docker/docker-compose in CI in Macos ARM VMs for now.

Checking both issues related in the description, they look related to not be available a docker distribution for architecture ARM. This support was added in https://github.com/elastic/package-registry/pull/1162

As a next steps for this issue:

I would say both issues could be closed since now all images run by elastic-package support multi-architecture.
It could be kept this issue open until there is support to run/install docker and run more tests in elastic-package CI pipelines.

WDYT @jlind23 @jsoriano ?

jsoriano commented 2 months ago

Agree on next steps, thanks!

mrodm commented 2 months ago

Closed both issues mentioned in the description (https://github.com/elastic/elastic-package/issues/497 and https://github.com/elastic/package-registry/issues/723) since Package Registry docker image already supports multi-platform images (linux/amd64 and linux/arm64).

mrodm commented 2 months ago

As mentioned in https://github.com/elastic/elastic-package/issues/539#issuecomment-2326551469 , this issue is kept open until there is support to run/install docker in our CI pipelines for Macos (if possible) ARM cc @kpollich