search

elastic / elastic-transport-ruby

Transport classes and utilities shared among Ruby Elastic client libraries
Apache License 2.0
5 stars 19 forks source link

warning: BigDecimal.new is deprecated; use BigDecimal() method instead. in multi_json 1.15.0 #42

Open hphucnp opened 2 years ago

hphucnp commented 2 years ago

We got the bigdecimal warning poping up every milisecond when using elasticsearch ruby client. Do anybody have anyidea to fix this issue?

/bundle/ruby/2.6.0/gems/multi_json-1.15.0/lib/multi_json/adapters/oj.rb:34: warning: BigDecimal.new is deprecated; use BigDecimal() method instead.
image

I think we can remove multi_json lib because it seems not to be maintained since 2020

picandocodigo commented 1 year ago

@hphucnp thanks for reporting this, I'll look into the possibility of replacing multi_json as the default serializer, since it seems to not be maintained anymore. I think we can add another implementation based off Elastic::Transport::Transport::Serializer::Base and keep this one as an option for backwards compatibility. Also, I'm transferring this issue to elastic-transport, since that's where the JSON serializer is used