elastic / elasticsearch-cloud-aws

AWS Cloud Plugin for Elasticsearch
https://github.com/elastic/elasticsearch/tree/master/plugins/discovery-ec2
577 stars 181 forks source link

Add China region for s3 and ec2 #156

Closed psu1025 closed 9 years ago

psu1025 commented 9 years ago

please add china region.

china region name is cn-north-1.

dadoonet commented 9 years ago

@psu1025 I think the patch I wrote a month ago won't work actually. China is not part of the S3 regions but part of Isolated Regions.

The patch I wrote uses for S3 s3-cn-north-1.amazonaws.com which is wrong because in that case the end point is s3.cn-north-1.amazonaws.com.cn.

Reopening to send a new fix.

rbraley commented 9 years ago

+1 this is blocking us

dadoonet commented 9 years ago

Closed by 4c02a017b43539d26964b639a71bf589cba1f72c