search

elastic / elasticsearch-cloud-aws

AWS Cloud Plugin for Elasticsearch
https://github.com/elastic/elasticsearch/tree/master/plugins/discovery-ec2
577 stars 181 forks source link

Add support for path_style_access #159

Closed dadoonet closed 8 years ago

dadoonet commented 9 years ago

Add a new option path_style_access for S3 buckets. It adds support for path style access for virtual hosting of buckets. Defaults to false.

Closes #124.

dadoonet commented 9 years ago

@tlrx wanna review this?

tlrx commented 9 years ago

Nice!

The AWS documentation says:

The path-style syntax, however, requires that you use the region-specific endpoint when attempting to access a bucket.

Are we sure that the repository creation will fail if it's not the case? Can we unittest it?

Also, can we unittest the path style access with a testing bucket configured with a virtual host like documented here? http://docs.aws.amazon.com/AmazonS3/latest/dev/VirtualHosting.html

dadoonet commented 8 years ago

Opened a PR in elasticsearch repo: https://github.com/elastic/elasticsearch/pull/15114