search

elastic / elasticsearch-cloud-aws

AWS Cloud Plugin for Elasticsearch
https://github.com/elastic/elasticsearch/tree/master/plugins/discovery-ec2
577 stars 181 forks source link

Snapshot S3Repository issue with eu-west-1 endpoint #171

Closed malpani closed 9 years ago

malpani commented 9 years ago

When region is null for snapshots, org.elasticsearch.repositories.s3.S3Repository tries to set the region as "EU" for eu-west-1 but the InternalS3AwsService does not recognize "EU" as a valid region

ankon commented 9 years ago

It seems that PR #169 is more logical here, as it avoids mixing well-known names of AWS with some newly introduced names like "EU"?

malpani commented 9 years ago

Either ways, considering InternalS3AwsService as a standalone library to access S3, guess it still makes sense to have this fix in place for completeness as EU is a valid region name - http://docs.aws.amazon.com/general/latest/gr/rande.html#s3_region

dadoonet commented 9 years ago

I agree with @ankon here and #169 will make it.

About region names vs. region ids, AWS plugin supports region ids actually. You can not set a region as US West (Oregon) AFAIK but as us-west-2. EU seems to be valid for LocationConstraint parameter we don't use.

Available names (ids) are: