Remove `cloud.account` and `cloud.key` settings

elastic / elasticsearch-cloud-aws

AWS Cloud Plugin for Elasticsearch

https://github.com/elastic/elasticsearch/tree/master/plugins/discovery-ec2

577 stars 181 forks source link

Remove `cloud.account` and `cloud.key` settings #183

Closed dadoonet closed 9 years ago

dadoonet commented 9 years ago

cloud.account and cloud.key settings are not documented as we use cloud.aws.access_key and cloud.aws.secret_key settings instead.

We can deprecated those settings in es-1.4 branch and remove them in master.

dadoonet commented 9 years ago

@imotov WDYT?

imotov commented 9 years ago

Personally I like cloud.account and cloud.key more (mostly because they are shorter). But I can see how this can cause some confusion. Not sure.

dadoonet commented 9 years ago

Yeah. If we want to mix within a node azure settings and aws settings (let say backup in two places), I think it's better to prefix setting name.

kimchy commented 9 years ago

we do support both, right? I mean, sure, we can simplify and not provide too many options to configure things and be more explicit around the actual aws settings

dadoonet commented 9 years ago

we do support both today. But the simplest form cloud.account is not documented AFAIK.

nikolay commented 9 years ago

@imotov With AWS, "account" and "access key" are two different things, so, cloud.account will be misleading.

dadoonet commented 9 years ago

This issue was moved to elastic/elasticsearch#12809