search

elastic / elasticsearch-cloud-aws

AWS Cloud Plugin for Elasticsearch
https://github.com/elastic/elasticsearch/tree/master/plugins/discovery-ec2
577 stars 181 forks source link

Add missing dependency on Apache HTTPCore 4.3.3 #201

Closed spencerwi closed 9 years ago

spencerwi commented 9 years ago

Fixes #200

dadoonet commented 9 years ago

We don't explicitly use any HTTPCore class in this plugin so we should not declare any dependency to it.

If there is any concern with a dependency provided by a lib, then you need to explicitly define the desired lib in your own pom.xml and potentially exclude it from cloud-aws dependency or Twilio dependency.

TBH I think that Twilio should better change its dependencies.

@tlrx WDYT?

spencerwi commented 9 years ago

This issue is not in cloud-aws but in ElasticSearch proper. Closing PR to get to the correct source of the problem.

dadoonet commented 9 years ago

In elasticsearch the dependency I can see is a test dependency. You should not have an issue with that. Other dependencies like this one are often shaded so you should not be concerned. Did I miss something else?

dadoonet commented 6 years ago

This repository is not maintained anymore. But thanks for reporting.