Add EC2/S3 Signer API setting

elastic / elasticsearch-cloud-aws

AWS Cloud Plugin for Elasticsearch

577 stars 181 forks source link

Closed dadoonet closed 9 years ago

dadoonet commented 9 years ago

If you are using a compatible EC2 or S3 service, they might be using an older API to sign the requests.

You can set your compatible signer API using cloud.aws.signer (or cloud.aws.ec2.signer and cloud.aws.s3.signer) with the right signer to use.

Defaults to AWS4SignerType.

Supported today (time when this commit is done):

Closes #155.

tlrx commented 9 years ago

I make two comments. Can we also have a test for this setting?

dadoonet commented 9 years ago

@tlrx I added a unit test so I wrote some changes in code.

dadoonet commented 9 years ago

@tlrx code updated. Let me know. Thanks!

tlrx commented 9 years ago

@dadoonet I made some comment concerning AwsSigner class which I think can be simplier.

dadoonet commented 9 years ago

@tlrx Agreed with your comments! Pushed a new commit. Let me know.

tlrx commented 9 years ago

@dadoonet thanks! LGTM