elastic / elasticsearch-cloud-aws

AWS Cloud Plugin for Elasticsearch
https://github.com/elastic/elasticsearch/tree/master/plugins/discovery-ec2
577 stars 181 forks source link

Fix non working update dynamic settings #203

Closed dadoonet closed 9 years ago

dadoonet commented 9 years ago

Described in https://github.com/elastic/elasticsearch/issues/10614, it's not possible with cloud discovery plugin to update dynamic settings anymore.

curl -XPUT localhost:9200/_cluster/settings -d '{
    "persistent" : {
        "discovery.zen.minimum_master_nodes" : 3
    },
    "transient" : {
        "discovery.zen.minimum_master_nodes" : 3
    }
}'

gives

{"acknowledged":true,"persistent":{},"transient":{}}

This patch makes that working again.

dadoonet commented 9 years ago

@imotov Could you review this PR please?

imotov commented 9 years ago

This change looks good to me, but I am wondering if we can somehow prevent this from happening in the future.

imotov commented 9 years ago

I have created PR that shows one possible way to prevent it. Not sure that it's the best way though.