search

elastic / elasticsearch-cloud-aws

AWS Cloud Plugin for Elasticsearch
https://github.com/elastic/elasticsearch/tree/master/plugins/discovery-ec2
577 stars 181 forks source link

Revert EC2/S3 Signer API setting #213

Closed dadoonet closed 9 years ago

dadoonet commented 9 years ago

In #202, we tried to add compatibility with older AWS SDK versions but it appears not to work as expected.

We think that it should be better to have a proper plugin to deal with other 3rd party AWS API and keep this repository up to date with AWS SDK.

It means that if a 3rd party EC2 or S3 like system is compatible with this plugin, that's perfectly fine using it. If not, users (or elastic) will need to build another plugin to support it.

Related to #202.

tlrx commented 9 years ago

The removal LGTM.

By the way #202 still help some users like https://github.com/elastic/elasticsearch-cloud-aws/issues/155#issuecomment-92789112. What have been done doesn't resolve #155 and CEPH compatibility but it still can help other users, no?

dadoonet commented 9 years ago

Thanks @tlrx. Let's wait for an answer from @herviou on this thread before pulling that in or close it.

dadoonet commented 9 years ago

We discussed this internally and the #202 PR might be helpful for some users. So let's keep it.

Closing.