elastic / elasticsearch-cloud-aws

AWS Cloud Plugin for Elasticsearch
https://github.com/elastic/elasticsearch/tree/master/plugins/discovery-ec2
577 stars 181 forks source link

Added v2 AWS API signer #238

Closed igor-kupczynski closed 8 years ago

igor-kupczynski commented 8 years ago

Hi,

There some discussion on Signer types in https://github.com/elastic/elasticsearch-cloud-aws/issues/155#issuecomment-102975211

If we want to use AWS v2 compatibile service then we need to use S3Signer. Right now this is not possible as this type is not registered. However, if we register it then it starts working.

This was tested on 1.6 branch with google cloud storage.

Thanks, Igor

dadoonet commented 8 years ago

w00t! I was not aware that Google storage is compatible with S3 API! :)

Sounds like you did not sign the CLA so far. Could you do it?

Also, would you mind opening such a PR against https://github.com/elastic/elasticsearch/tree/master/plugins/cloud-aws instead? We will maintain this plugin there from 2.0 and we most likely only fix bugs here.

Thanks a lot!

igor-kupczynski commented 8 years ago

Hi,

It is if you enable interoperability https://cloud.google.com/storage/docs/migrating?hl=en :-)

Sure, I'll sign the CLA and open the new PR tomorrow. Closing this for now

Thanks, Igor