elastic / elasticsearch-cloud-aws

AWS Cloud Plugin for Elasticsearch
https://github.com/elastic/elasticsearch/tree/master/plugins/discovery-ec2
577 stars 181 forks source link

Restart server if aws key changes in config? #260

Closed HenleyChiu closed 8 years ago

HenleyChiu commented 8 years ago

Do I need to restart my Elastic server if I change the AWS key in my elasticsearch.yml config file?

dadoonet commented 8 years ago

AWS Client is created on a node level as soon it's needed and then is cached indefinitely. It means that you need to restart the node.

Also, elasticsearch.yml file is read only once when the node starts. Even if the plugin was able to provide a smarter cache with expiration every x minutes for example, it would not be able to read the new settings.

@clintongormley WDYT? If doable, should we try to provide a hot reload mechanism for cloud clients (azure, aws and gce)?

clintongormley commented 8 years ago

@dadoonet No I don't. Too much can go wrong

dadoonet commented 8 years ago

Thank you @clintongormley.

Closing.