search

elastic / elasticsearch-docker

Official Elasticsearch Docker image
Apache License 2.0
789 stars 240 forks source link

Fix node name logging #217

Closed jasontedor closed 5 years ago

jasontedor commented 5 years ago

In upstream Elasticsearch we have modified how the node name is logged. This commit makes the logging configuration in the Docker image consistent with this change.

jasontedor commented 5 years ago

Relates elastic/elasticsearch#31588

nik9000 commented 5 years ago

Do we have an extra space in the builtin pattern? I thought we did but I'm on mobile now.

On Sat, Nov 17, 2018, 20:14 Jason Tedor <notifications@github.com wrote:

@jasontedor https://github.com/jasontedor requested your review on: #217 https://github.com/elastic/elasticsearch-docker/pull/217 Fix node name logging.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/elastic/elasticsearch-docker/pull/217#event-1973024809, or mute the thread https://github.com/notifications/unsubscribe-auth/AANLos8nf4MCZtqe8xFHp-5jDDo7TCH6ks5uwLRogaJpZM4YnuX8 .

jasontedor commented 5 years ago

Nope. See: https://github.com/elastic/elasticsearch/blob/v6.5.0/distribution/src/config/log4j2.properties#L16

nik9000 commented 5 years ago

Lgtm then. Thanks for the link!

On Sat, Nov 17, 2018, 20:43 Jason Tedor <notifications@github.com wrote:

Nope. See:

https://github.com/elastic/elasticsearch/blob/v6.5.0/distribution/src/config/log4j2.properties

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/elastic/elasticsearch-docker/pull/217#issuecomment-439660981, or mute the thread https://github.com/notifications/unsubscribe-auth/AANLompJPUy8Un8hac4ixGD9G65ehjAZks5uwLslgaJpZM4YnuX8 .