search

elastic / elasticsearch-java

Official Elasticsearch Java Client
Apache License 2.0
408 stars 237 forks source link

Add improvements to response _DESERIALIZER #772

Closed shinsj4653 closed 3 months ago

shinsj4653 commented 5 months ago

This PR adds a number of enhancements to several response classes.

co.elastic.clients.elasticsearch.security:

co.elastic.clients.elasticsearch.indices:

For the response that returns an empty object, or has a possibility according to the server-side code, _DESERIALIZER should use emptyObject(T) from the JsonpDeserializer.

For more detailed specifications regarding this PR, please refer to https://github.com/elastic/elasticsearch-java/issues/718#issuecomment-2027988172.

henryptung commented 5 months ago

Looks fine to me at a glance, but unfortunately not in a position to test ATM and don't have permissions to make a useful review.

shinsj4653 commented 4 months ago

Appreciate for the feedback! I hope to get further comments from this open source administrators.

l-trotta commented 3 months ago

Closing this because it was fixed in the code generator