Is including tap files into the npm bundles intentional?

elastic / elasticsearch-js

Official Elasticsearch client library for Node.js

https://ela.st/js-client

Apache License 2.0

29 stars 731 forks source link

Is including tap files into the npm bundles intentional? #2483

Closed Marsup closed 5 days ago

Marsup commented 6 days ago

Question

Hi,

I guess the title says it all, but the .tap folder has been included in the npm packages (and it's fairly big) since 8.15.2. I intended to propose a patch to add this folder to .gitignore, but probably a developer would have seen it locally, so maybe that's intentional?

Thanks.

JoshMock commented 5 days ago

It's not intentional! Thanks for catching that. Fixed in https://github.com/elastic/elasticsearch-js/pull/2487 and will be publishing 8.15.3 and 8.16.2 with the correction.