elastic / elasticsearch-metrics-reporter-java

Metrics reporter, which reports to elasticsearch
Apache License 2.0
231 stars 103 forks source link

Leveraging standard elasticsearch nodes #11

Open johnament opened 9 years ago

johnament commented 9 years ago

In your docs, you write

In case, you are worried, that you need to include the 20MB elasticsearch dependency in your project, you do not need to be.

The problem is that I'm already including this 20 MB dependency in my code. In fact, its better for us this way for a number of reasons:

So I have to wonder, can you consider supporting the standard node configuration out of the box, e.g. in your builder add

withClient(Client)

Or even

withSettings(Settings)

To allow a fully configurable connection, without the need to already use ElasticSearch (honestly though, the reason this reporter interests me is because I already use ElasticSearch in my app, so it makes sense)

spinscale commented 9 years ago

As the reporter is using HTTP instead of the transport protocol, I would need to write an additional reporter using the client. You could potential use the guice injector in your own code to get some of the information that you need.