search

elastic / elasticsearch-migration

This plugin will help you to check whether you can upgrade directly to the next major version of Elasticsearch, or whether you need to make changes to your data and cluster before doing so.
290 stars 32 forks source link

Check for default date format breaking change in migration plugin #54

Closed clintongormley closed 8 years ago

clintongormley commented 8 years ago

From @ppf2 on April 4, 2016 18:17

Elasticsearch version: 1.7.x

Description of the problem including expected versus actual behavior:

There is a breaking change related to default date formats: https://www.elastic.co/guide/en/elasticsearch/reference/2.3/breaking_20_mapping_changes.html#_date_fields_and_unix_timestamps

While the migration plugin cannot tell what data values users will actually pass into the date field, it will still be nice to warn users about this breaking changes or as an advisory note for this can become a breaking change at runtime.

Copied from original issue: elastic/elasticsearch#17517

clintongormley commented 8 years ago

Given that this is for new date fields created in 2.x not existing fields in 1.x, I don't think we should warn just because the user has date fields. That's what reading the breaking changes docs is for.