Report plugin install changes in red, not blue?

elastic / elasticsearch-migration

This plugin will help you to check whether you can upgrade directly to the next major version of Elasticsearch, or whether you need to make changes to your data and cluster before doing so.

290 stars 32 forks source link

Report plugin install changes in red, not blue? #75

Closed ppf2 closed 7 years ago

ppf2 commented 7 years ago

It is more appropriate to mark the splitting of the single Azure/AWS/GCE plugin into 2 plugins as red so that users can take action to update any puppet/chef/automation script to reference a different plugin name moving forward.

Similarly, maybe also do the same for watcher/shield/marvel-agent/graph/license -> x-pack?

eskibars commented 7 years ago

Right now, renamed plugins show in blue and removed plugins show in yellow. I'm not sure whether red or yellow is more appropriate here. It seems like a yellow situation to me for both of them, but I don't know that the levels are really so discretely defined.

ppf2 commented 7 years ago

Oh yah I forgot there's such thing as yellow. So yellow fits too, better than blue (because the blue description text says no action needed) :)

clintongormley commented 7 years ago

Changed to yellow