search

elastic / elasticsearch-parent

Elasticsearch Parent POM
Apache License 2.0
3 stars 10 forks source link

[maven] use parent dir for dev-tools directory #45

Closed dadoonet closed 8 years ago

dadoonet commented 9 years ago

When using dev-tools in a sub project, maven can not find the dev-tools dir inside the sub module it self.

To fix that, we need to set that elasticsearch.tools.directory is actually using the parent dir.

<elasticsearch.tools.directory>${project.parent.build.directory}/dev-tools</elasticsearch.tools.directory>

Note that the issue could still appear if you are defining a sub module of the first module.

parent->plugins->myplugin might not be able to find it.

A workaround could be to keep ${project.build.directory} in parent project. But define in plugins pom.xml ${project.parent.build.directory} and in myplugin pom.xml ${project.parent.parent.build.directory}.

@rmuir WDYT?

dadoonet commented 9 years ago

@rmuir I think that this PR should be pulled in before we refactor the main repository. IIRC if you want to run some tests, you will need to mvn install this branch first locally.

dadoonet commented 8 years ago

Useless now. Closing.