elastic / elasticsearch-parent

Elasticsearch Parent POM
Apache License 2.0
3 stars 10 forks source link

[maven] move elasticsearch-plugin pom artifact to o.e.plugin groupId #47

Closed dadoonet closed 8 years ago

dadoonet commented 9 years ago

I think we should move from:

<parent>
    <groupId>org.elasticsearch</groupId>
    <artifactId>elasticsearch-plugin</artifactId>
    <version>2.0.0-SNAPSHOT</version>
</parent>

to

<parent>
    <groupId>org.elasticsearch.plugin</groupId>
    <artifactId>elasticsearch-plugin</artifactId>
    <version>2.0.0-SNAPSHOT</version>
</parent>

So plugins we produce then will use also the same groupId. For example, we could move kuromoji to:

<groupId>org.elasticsearch.plugin</groupId>
<artifactId>elasticsearch-analysis-kuromoji</artifactId>
<version>2.0.0-SNAPSHOT</version>

(instead of 3.0.0-SNAPSHOT) BTW.

@rmuir WDYT?

rmuir commented 9 years ago

if it prevents any confusion from pluginmanager, this seems like a good solution to me. then we don't have to rename all artifacts.

dadoonet commented 9 years ago

@rmuir It won't solve the plugin manager issue as the plugin manager don't rely on the groupId. Unless we download using groupId/artifactId/version notation which will download from maven central.

We can imagine different solutions about this but to me it's outside of the scope of this issue.

But as I said, I think it should be another discussion than this thread.

dadoonet commented 9 years ago

I thought again about it. Actually, there is not really need to change the plugin manager but just to change the documentation and the release scripts. If we consider that we now upload whatever plugin to S3 download.elasticsearch.org bucket in groupId/name/name-version instead of elasticsearch/name/name-version, we just have to tell people to use bin/plugin install groupId/name/version and this should work out of the box.

But of course, we could simplify this in the plugin manager as well.