search

elastic / elasticsearch-php

Official PHP client for Elasticsearch.
https://www.elastic.co/guide/en/elasticsearch/client/php-api/current/index.html
MIT License
5.26k stars 965 forks source link

Update Connection.php #1121

Closed mamsincl closed 7 months ago

mamsincl commented 3 years ago

Fix function signature of performRequest to match declaration in ConnectionInterface

Issue:

Fatal error: 
Declaration of Elasticsearch\Connections\Connection::performRequest($method, $uri, $params = NULL, $body = NULL, $options = Array, ?Elasticsearch\Transport $transport = NULL) 
must be compatible with 
Elasticsearch\Connections\ConnectionInterface::performRequest(string $method, string $uri, ?array $params = Array, $body = NULL, array $options = Array, ?Elasticsearch\Transport $transport = NULL) 
in /mnt/volume-lon1-01/var/www/xxxx/vendor/elasticsearch/elasticsearch/src/Elasticsearch/Connections/Connection.php on line 49

https://github.com/elastic/elasticsearch-php/issues/989 - but for 6.8.x function missing all type hinting

elasticmachine commented 3 years ago

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

ezimuel commented 7 months ago

We are not supporting anymore 6.x, sorry for that.