Update search iterators to send "scroll_id" inside the request body

elastic / elasticsearch-php

Official PHP client for Elasticsearch.

https://www.elastic.co/guide/en/elasticsearch/client/php-api/current/index.html

MIT License

35 stars 970 forks source link

Update search iterators to send "scroll_id" inside the request body #1134

Closed bakurin closed 3 years ago

bakurin commented 3 years ago

Moving scroll_id into requires body #1044 brakes SearchResponseIterator by triggering deprecation error.

The goal of this PR is to change the iterator classes as described in the doc to avoid deprecation error

elasticmachine commented 3 years ago

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

ezimuel commented 3 years ago

Thanks @bakurin, this PR will be released in 7.14.0.