Refactor for abstract return type

elastic / elasticsearch-php

Official PHP client for Elasticsearch.

https://www.elastic.co/guide/en/elasticsearch/client/php-api/current/index.html

MIT License

35 stars 970 forks source link

Refactor for abstract return type #1150

Closed bluedreamer closed 2 years ago

bluedreamer commented 3 years ago

PHP 7.4 complains now about return types on abstract functions. This is an issue for my using CirrusSearch mediawiki module. I see this is fixed in later branches but not for the 6.7.x stream

elasticmachine commented 3 years ago

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

cla-checker-service[bot] commented 3 years ago

❌ Author of the following commits did not sign a Contributor Agreement: 5d5863224d06a403d889722fb85686064a791b6e

Please, read and sign the above mentioned agreement if you want to contribute to this project

bluedreamer commented 3 years ago

I did sign one, does the signing take time to propagate?

Electronic Record and Signature Disclosure: Accepted: 6/30/2021 11:26:41 PM ID: 6cf300e3-5b1d-4787-be78-2ae94885d39b

bluedreamer commented 3 years ago

Any advice on how to get the CLA passed and my guess is the CI failures need to be fixed too - but I don't known what is wrong. The errors seems nothing to do with my change (but must be) - any help apprecated as to where to look next.

ezimuel commented 2 years ago

@bluedreamer sorry for the very late reply. Is this still an issue? If so, please send a new PR to 6.8.x branch and I'll review asap. Thanks!