Add the API compatibility header in v8

elastic / elasticsearch-php

Official PHP client for Elasticsearch.

https://www.elastic.co/guide/en/elasticsearch/client/php-api/current/index.html

MIT License

5.26k stars 965 forks source link

Add the API compatibility header in v8 #1233

Closed ezimuel closed 2 years ago

ezimuel commented 2 years ago

This PR adds the API compatibility header in client v8. This should solve issue https://github.com/elastic/elasticsearch-php/issues/1221

ezimuel commented 2 years ago

@technige the PHP test are failing because we a license issue running Elasticsearch using elastic/elastic-github-actions/elasticsearch@master. The CI tests are ok.

NikosDevPhp commented 1 year ago

@ezimuel Shouldn't this be optional, having a flag to control it?

We are currently trying to use client v.8 with server v.7. I understand the compatibility header is for the other way around (working with server v.8 and client v.7) but I see requests are working okay in our setup without compatibility headers added.