elastic / elasticsearch-php

Official PHP client for Elasticsearch.
https://www.elastic.co/guide/en/elasticsearch/client/php-api/current/index.html
MIT License
5.26k stars 966 forks source link

allow plugin for php-http/discovery library #1294

Closed hkulekci closed 1 year ago

hkulekci commented 1 year ago

According to this change of php-http/discovery library, we need to allow the plugin on composer.json. So I initialize this PR to add this.

elasticmachine commented 1 year ago

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

hkulekci commented 1 year ago

So, we are using elasticsearch client in this library: https://github.com/matchish/laravel-scout-elasticsearch/pull/230 The plugin error occurred while running the tests. You can check here: https://github.com/matchish/laravel-scout-elasticsearch/actions/runs/4156971917/jobs/7191125500

ping @ezimuel

hkulekci commented 1 year ago

Let me rebase to main. @ezimuel

hkulekci commented 1 year ago

Rebased to main after this change.

ezimuel commented 1 year ago

Thanks @hkulekci

hkulekci commented 1 year ago

I don't know why the test gives an error for the docker snapshot. I thought that "Unified Release Manager Check" would give an output for the following workflows. But also, tests are looking for docker.elastic.co/elasticsearch/elasticsearch:8.8-SNAPSHOT. And this snapshot is not available in https://www.docker.elastic.co/r/elasticsearch even.

Unable to find image 'docker.elastic.co/elasticsearch/elasticsearch:8.8-SNAPSHOT' locally

I could not follow the all PRs recently. Is this error typical, or known issue

ezimuel commented 1 year ago

@hkulekci the error is fine :-) This is because we don't have a 8.8-SNAPSHOT artifact yet. I'm working to fix the other CI errors, like this one.

hkulekci commented 1 year ago

Ah okay. Thanks. ✌️ That error is interesting, too. There is no explanation on raw logs why the operation was canceled, even. I thought that all the other tests were forced to skip/cancel if one of them got an error. Because there is no explanation on raw logs too :

2023-02-13T08:29:28.7213113Z ##[endgroup]
2023-02-13T08:29:29.3417621Z > phpstan analyse src --level 2 --no-progress
2023-02-13T08:29:29.6421715Z 
2023-02-13T08:29:29.6463535Z  ! [NOTE] The Xdebug PHP extension is active, but "--xdebug" is not used. This  
2023-02-13T08:29:29.6464319Z  !        may slow down performance and the process will not halt at            
2023-02-13T08:29:29.6465170Z  !        breakpoints.                                                          
2023-02-13T08:29:29.6465581Z 
2023-02-13T08:29:29.9189462Z Note: Using configuration file /home/runner/work/elasticsearch-php/elasticsearch-php/phpstan.neon.
2023-02-13T08:29:37.3967314Z 
2023-02-13T08:29:37.3994579Z  [OK] No errors                                                                 
2023-02-13T08:29:37.4000209Z 
2023-02-13T08:29:37.4825999Z ##[error]The operation was canceled.       <---------
2023-02-13T08:29:37.4902235Z Post job cleanup.
2023-02-13T08:29:37.6301073Z [command]/usr/bin/git version
2023-02-13T08:29:37.6355728Z git version 2.39.1
ezimuel commented 1 year ago

@hkulekci I tried to remove xdebug in PHP used by the test. Can you rebase from main? Thanks.

hkulekci commented 1 year ago

@ezimuel Done!

ezimuel commented 1 year ago

Thanks @hkulekci for your contribution.