search

elastic / elasticsearch-php

Official PHP client for Elasticsearch.
https://www.elastic.co/guide/en/elasticsearch/client/php-api/current/index.html
MIT License
5.26k stars 966 forks source link

SearchHitIterators and SearchResponseIterator helpers revised with new version #1302

Closed hkulekci closed 1 year ago

hkulekci commented 1 year ago

We have problems related to the PHPStan check. I had already mentioned in issue #1301

elasticmachine commented 1 year ago

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

ezimuel commented 1 year ago

jenkins test this please

hkulekci commented 1 year ago

I think the tests will be broken because of phpstan. 🥹 I could not find a way to ignore with comment or put that methods into interface.

hkulekci commented 1 year ago

I ignored the lines from PHPStan. But, the test is broken again because of another reason.

hkulekci commented 1 year ago

Ping @ezimuel

hkulekci commented 1 year ago

I could not understand the tests that throw errors. As I remember, we got the same error before. 

Unable to find image 'docker.elastic.co/elasticsearch/elasticsearch:8.8-SNAPSHOT' locally
docker: Error response from daemon: manifest for docker.elastic.co/elasticsearch/elasticsearch:8.8-SNAPSHOT not found: manifest unknown: manifest unknown.
ezimuel commented 1 year ago

Thanks @hkulekci for the PR and sorry for the late reply.

hkulekci commented 1 year ago

Thanks for merging 🕺