elastic / elasticsearch-php

Official PHP client for Elasticsearch.
https://www.elastic.co/guide/en/elasticsearch/client/php-api/current/index.html
MIT License
5.25k stars 964 forks source link

Fix Response\Elasticsearch::offsetGet return type deprecation #1352

Closed marcortola closed 6 months ago

marcortola commented 10 months ago

"ArrayAccess::offsetGet()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "Elastic\Elasticsearch\Response\Elasticsearch" now to avoid errors or add an explicit @return annotation to suppress this message.

elasticmachine commented 10 months ago

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

cla-checker-service[bot] commented 10 months ago

❌ Author of the following commits did not sign a Contributor Agreement: e2273af0902eba44cbd55def02ee2f48d25225d6

Please, read and sign the above mentioned agreement if you want to contribute to this project

AnnaNtagiou commented 8 months ago

@marcortola could you please sign the CLA and rebase?