Consider using pyproject.toml replace setup.py

elastic / elasticsearch-py

Official Python client for Elasticsearch

https://ela.st/es-python

Apache License 2.0

4.23k stars 1.18k forks source link

Open ischaojie opened 1 year ago

ischaojie commented 1 year ago

Describe the feature:

pyproject.toml has become the de facto python project standard, perhaps we should replace the current setup.py with a tool such as hatch?

sethmlarson commented 1 year ago

That would be a great improvement, let's use Hatch.

NamanJainCG commented 1 year ago

Hey, can someone help me solve this here, I am a beginner. Thanks in advance

pquentin commented 1 year ago

Hello, I would suggest that you read https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html and https://packaging.python.org/en/latest/tutorials/packaging-projects/ first. You will also have to remove setup.py from noxfile.py and MANIFEST.in, and adjust the code in utils/build-dists.py to change the version in pyproject.toml.

pquentin commented 10 months ago

That said, #2156 exists so I need to review it instead.