Fix node_pool_class override

elastic / elasticsearch-py

Official Python client for Elasticsearch

https://ela.st/es-python

Apache License 2.0

4.22k stars 1.18k forks source link

Fix node_pool_class override #2581

Closed tallakh closed 4 months ago

tallakh commented 4 months ago

Its currently not working to submit a custom node_pool_class when creating a AsyncElasticsearch/Elasticsearch client. This PR fixes this.

Fixes https://github.com/elastic/elasticsearch-py/issues/2578

github-actions[bot] commented 4 months ago

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

* Rebuild this PR: `run docs-build` * Rebuild this PR and all Elastic docs: `run docs-build rebuild` _{`run docs-build` is much faster than `run docs-build rebuild`. A `rebuild` should only be needed in rare situations.} _{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status [here](https://buildkite.com/elastic/docs-build).}

pquentin commented 4 months ago

Thanks! I've added a test. Does that look good to you? Are you OK with me reusing your NoTimeoutConnectionPool?

pquentin commented 4 months ago

buildkite test this please

tallakh commented 4 months ago

Thanks! I've added a test. Does that look good to you? Are you OK with me reusing your NoTimeoutConnectionPool?

Sure, no problem! And thanks for adding the tests, should have taken the time to do it myself. This looks good now 👍