elastic / elasticsearch-py

Official Python client for Elasticsearch
https://ela.st/es-python
Apache License 2.0
4.17k stars 1.17k forks source link

feat: extend default settings in AsyncVectorStore #2602

Closed minglu7 closed 6 days ago

minglu7 commented 1 week ago

This commit introduces a new parameter, custom_settings, to the AsyncVectorStore class. This allows users to provide their own settings that will extend the default settings. This increases the flexibility of the class and allows it to be tailored to specific use cases. The custom settings are applied in the _create_index_if_not_exists method.

github-actions[bot] commented 1 week ago

A documentation preview will be available soon.

Request a new doc build by commenting * Rebuild this PR: `run docs-build` * Rebuild this PR and all Elastic docs: `run docs-build rebuild` `run docs-build` is much faster than `run docs-build rebuild`. A `rebuild` should only be needed in rare situations. If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status [here](https://buildkite.com/elastic/docs-build).
miguelgrinberg commented 1 week ago

@minglu7 Thanks for your contribution! I have made a couple of suggested changes for you to consider.

You also need to run nox -rs format to ensure that the change that you've made in the async version of the Vectorstore class is also applied on the synchronous version. Then you will include the changes to both versions in this PR.

Finally, it would be useful if you can add a unit test in test_elasticsearch/test_server/test_vectorstore/test_vectorstore.py.

Thanks, again!

pquentin commented 1 week ago

buildkite test this please

pquentin commented 1 week ago

buildkite test this please

minglu7 commented 1 week ago

buildkite test this please

send it again please

pquentin commented 1 week ago

buildkite test this please

minglu7 commented 1 week ago

buildkite test this please

check these changed files, please

pquentin commented 1 week ago

buildkite test this please

miguelgrinberg commented 6 days ago

buildkite test this please