search

elastic / elasticsearch-rails

Elasticsearch integrations for ActiveModel/Record and Ruby on Rails
Apache License 2.0
3.07k stars 797 forks source link

Address Rails 7.1 deprecation warning in elasticsearch-rails #1067

Closed maciek-rr closed 5 months ago

maciek-rr commented 10 months ago

Description

This PR switches the elasticsearch-rails gem to use a new signature of the ActiveSupport::LogSubscriber#color method when called in an app using Rails 7.1+.

With older Rails, the gem uses the working, old signature.

An example of a deprecation warning visible in 7.1 apps 

DEPRECATION WARNING: Bolding log text with a positional boolean is deprecated and will be removed in Rails 7.2. Use an option hash instead (eg. `color("my text", :red, bold: true)`). (called from query_time_boundaries at timeseries/frequency_calculator.rb:44)
spuyet commented 6 months ago

@picandocodigo do you plan to merge that MR into main ?

I see that you're working on a new version for this gem, do we have any kind if ETA for the release ? thx 😄

r-plus commented 4 months ago

hello

Do you have any plan about this PR backport to 7.x branch?