elastic / elasticsearch-rs

Official Elasticsearch Rust Client
https://www.elastic.co/guide/en/elasticsearch/client/rust-api/current/index.html
Apache License 2.0
695 stars 70 forks source link

Makefile improvements. #142

Closed sagiegurari closed 3 years ago

sagiegurari commented 3 years ago

Really cool crate. Trying to help a bit sort out and remove duplications in the makefile.

Few questions/comments

  1. I couldn't test it properly. i'm working on gitpod and i can't run docker. would love some help testing this.
  2. why did you have the windows specific overrides? i understand why you need those when using script (that's why i converted to command+args which support var value replacement) but for start/stop elasticsearch tasks i'm not sure why it was needed. I don't have a windows machine to test (again need help with that as well) so i would love to understand more why your original tasks didn't work. because it looks like for those you simply also defined STACK_VERSION and TEST_SUITE on the command, but those env vars are already set.
cla-checker-service[bot] commented 3 years ago

💚 CLA has been signed

elasticmachine commented 3 years ago

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

sagiegurari commented 3 years ago
sagiegurari commented 3 years ago

@russcam I think everything is handled, but can you double check?