search

elastic / elasticsearch-rs

Official Elasticsearch Rust Client
https://www.elastic.co/guide/en/elasticsearch/client/rust-api/current/index.html
Apache License 2.0
705 stars 72 forks source link

Derive Clone on Bulk request structs #202

Closed jefftt closed 1 month ago

jefftt commented 2 years ago

Addresses https://github.com/elastic/elasticsearch-rs/issues/195

This option is the least invasive as it doesn't change the type signatures although it requires extra allocations in order to clone the struct. Allowing body to take a reference to a slice of operations instead of ownership would be a more efficient solution that could be addressed in a separate PR

elasticmachine commented 2 years ago

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

cla-checker-service[bot] commented 2 years ago

💚 CLA has been signed

jefftt commented 2 years ago

i signed the CLA but not sure github is being updated properly

jefftt commented 2 years ago

oh there we go

jefftt commented 1 year ago

Hi @russcam - any interest in this change?

russcam commented 1 year ago

Hey @jefftt, I no longer work for Elastic so no longer have access rights to this repository to work with you on this PR. Perhaps @swallez or @sethmlarson can work with you to get this in?