search

elastic / elasticsearch-rs

Official Elasticsearch Rust Client
https://www.elastic.co/guide/en/elasticsearch/client/rust-api/current/index.html
Apache License 2.0
702 stars 72 forks source link

[INFRA] Setting up pull request CI #54

Open russcam opened 4 years ago

russcam commented 4 years ago

Currently, there are a couple of basic checks in place for PRs:

  1. CLA check
  2. Clippy check

In line with other official client repositories, a Continuous Integration should be configured to:

  1. run unit tests
  2. run integration tests
  3. check for dead links in documentation

on PRs.

mindbat commented 4 years ago

appears in a puff of smoke

Did someone say infra?

russcam commented 4 years ago

Yes @mindbat 😃 Clients typically use https://clients-ci.elastic.co/ for running the YAML spec tests (#19). I was thinking that GitHub actions might work better for the above?

mindbat commented 4 years ago

I was thinking that GitHub actions might work better for the above?

I'm not as familiar with those, though I know the @elastic/infra-automation team has been experimenting with them.

But as far as running unit & integration tests, then posting results back on the PR, clients-ci should work fine for that :)

mwilliammyers commented 4 years ago

I vote for GitHub actions 😄

It is really handy to have it built into the GitHub UI for open source projects...

bryantbiggs commented 4 years ago

Actions are great - there are some pretty good rust ones https://github.com/actions-rs?type=source if you haven't already come across those

russcam commented 3 years ago

Clients CI environment now runs all yaml tests for a PR, but I think it would be useful to run all the tests in the elasticsearch create