[DISCUSS] Exposing request details on the response

elastic / elasticsearch-rs

Official Elasticsearch Rust Client

https://www.elastic.co/guide/en/elasticsearch/client/rust-api/current/index.html

Apache License 2.0

705 stars 72 forks source link

[DISCUSS] Exposing request details on the response #6

Closed russcam closed 4 years ago

russcam commented 4 years ago

Should ElasticsearchResponse expose details of the request? If so, which ones?

HttpMethod?
The constructed url?
The request body? If so, JSON string representation, bytes, struct, something else?

Does it make sense to expose these on ElasticsearchResponse, or should they be exposed through some other means e.g. event hooks? Some of the discussion around this would feed into a conversation about diagnostic tracing/logging within the client.

russcam commented 4 years ago

Opened #96 for details that have proved useful whilst working on the yaml test runner.