search

elastic / elasticsearch-rs

Official Elasticsearch Rust Client
https://www.elastic.co/guide/en/elasticsearch/client/rust-api/current/index.html
Apache License 2.0
695 stars 71 forks source link

[DISCUSS] Currently requires nightly release of rustc due to external_doc #87

Closed lucca-fraser closed 4 years ago

lucca-fraser commented 4 years ago

This crate appears to require the nightly release of rustc, solely due to its use of the external_doc feature. It would be convenient if the crate were buildable with the stable release. Is there any way to avoid the use of this feature for the time being?

mwilliammyers commented 4 years ago

Valid question :)

The plan is to move off of nightly, but in addition to that usage, there are at least a few (indirect) dependencies that rely on nightly, see this comment.

russcam commented 4 years ago

I've opened https://github.com/elastic/elasticsearch-rs/pull/89 to address. With a build.rs script to detect rustc version and some cfg_attr, elasticsearch can work with rust stable whilst still also allowing README to be tested with external_doc feature with

cargo +nightly test -p elasticsearch --doc

api_generator still needs rust nightly, but this isn't an impediment as it's not a published package.