Ensure qaf knows it's running in CI

elastic / elasticsearch-serverless-python

Official Python client for Elasticsearch Serverless

Apache License 2.0

9 stars 4 forks source link

Ensure qaf knows it's running in CI #16

Closed JoshMock closed 1 year ago

JoshMock commented 1 year ago

Latest tests of the qaf integration test runner are getting confused about which Vault instance to connect to. I forgot we needed to make sure the Docker image knows it's running in Buildkite in order to access Vault CI.

JoshMock commented 1 year ago

Hmm. Still failing but for new reasons.

Switching to draft so I can figure this out.

JoshMock commented 1 year ago

Missing a permission to a shared secret in Vault. Waiting on a CI config change before retesting this.

JoshMock commented 1 year ago

The latest build on this PR shows integration tests are still failing, but it seems able to fetch secrets appropriately, so I'll merge this fix for that specific issue.

@pquentin Figuring out what is causing test_async/test_server/test_rest_api_spec.py tests to fail is another handoff item. Seems to be something happening during test teardown.