elastic / elasticsearch-specification

Elasticsearch full specification
Apache License 2.0
121 stars 71 forks source link

Optional field id in hit class #2592

Closed l-trotta closed 4 months ago

l-trotta commented 4 months ago

as the comment just above the field says:

'_id' is not available when using 'stored_fields: _none_'

github-actions[bot] commented 4 months ago

Following you can find the validation results for the API you have changed.

API Status Request Response
search :red_circle: 1433/2083 2016/2065

You can validate this API yourself by using the make validate target.

github-actions[bot] commented 4 months ago

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-2592-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b1f91f1a0ae5d09da92cf0859b0ff92410cdb6e3
# Push it to GitHub
git push --set-upstream origin backport-2592-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-2592-to-7.17.